search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
572 stars 99 forks source link

Fix ipmi pool api #554

Closed michaeljs1990 closed 7 years ago

michaeljs1990 commented 7 years ago

I messed this up somehow even though I checked it a ton of times. Not sure how i missed this but I have since learned pattern matching in scala sets is not that simple. This correctly matches against Sets and non Sets. I updated the test to check for the case of two pools being returned since it additionally checks for the case that one pool can be returned.

I spend far too much time trying to get different configs to work with the tests I had some luck using FakeApplication and setting some additionalConfig for it. However it turns out that if you have two tests using fake config and they are both different only the first test that runs fake config takes effect and it applies to all the other runs...

byxorna commented 7 years ago

pinging @roymarantz @defect to review as well.