search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
572 stars 99 forks source link

method getLshwValues is defined twice #559

Closed t1mota closed 7 years ago

t1mota commented 7 years ago

during compile got this error

[error] /root/src/collins/app/collins/models/AssetMeta.scala:220: method getLshwValues is defined twice [error] conflicting symbols both originated in file '/root/src/collins/app/collins/models/AssetMeta.scala' [error] def getLshwValues(): Set[AssetMeta] = { [error] ^ [error] one error found [error] (compile:compile) Compilation failed [error] Total time: 277 s, completed Jun 22, 2017 3:48:15 PM

byxorna commented 7 years ago

@t1mota how are you building this? Have you tried a git clean -xxd? The build is passing on master branch (see readme) so it must be some oddities with your environment, build tooling, etc.

yl3w commented 7 years ago

It is defined twice

https://github.com/tumblr/collins/blob/master/app/collins/models/AssetMeta.scala#L216

byxorna commented 7 years ago

@maddalab lovely. somehow travis only is running ruby builds; not scala (RUN_SCALA=false for all builds). Doesnt seem like the travis file has changed recently... we need to readd the scala build to the build matrix. https://github.com/tumblr/collins/blame/master/.travis.yml#L33-L40 (between travis build 856 and 857 travis stopped running scala builds -_-)

byxorna commented 7 years ago

@t1mota fix committed; wait a bit for the new container to build, and git/docker pull again? Thanks for reporting this!