Adding support for tracking Motherboard and BIOS firmware information

tumblr / collins

groovy kind of love

tumblr.github.com/collins

Apache License 2.0

573 stars 99 forks source link

Adding support for tracking Motherboard and BIOS firmware information #567

Closed jyundt closed 6 years ago

jyundt commented 6 years ago

I'm open to suggestions on the best way to track this information, but here is an initial stab.

Screenshot of the updated Server Base hardware details view:

I added four tests to validate the motherboard/BIOS info is correct. Let me know if there are any other edge cases that would be appropriate.

(For some background our hardware teams are going to start using this information and we'd like to get it into collins.)

Fixes tumblr/collins#555

cc @michaeljs1990 @byxorna

jyundt commented 6 years ago

cc @nshalman

nshalman commented 6 years ago

IIRC someone from hardware suggested tracking the firmware build date as well.

jyundt commented 6 years ago

IIRC someone from hardware suggested tracking the firmware build date as well.

Yeah I just realized I didn't include that. I'll update this shortly.

byxorna commented 6 years ago

I am not sure where the line lies, but at some point collecting "facts" about your hardware during induction in genesis and setting normal attributes may be less resistance than needing to extract info from LSHW and bake straight into collins' hardware details. For bios/board model/version, its definitely useful to have in the hardware details. For other, more esoteric fields, I'd err more on the you-set-whatever-attributes-you-want-during-induction side :P

byxorna commented 6 years ago

@jyundt i like it. anything else that would be generally useful that we should get into this evolution before landing this? cc @roymarantz @defect @gtorre @qx-xp

defect commented 6 years ago

Only took a quick glance but i like it! I'll fire it up tomorrow and try it out a little more closely.

byxorna commented 6 years ago

@defect lets land this?

defect commented 6 years ago

Yeah, definitely. I wanted to run the LSHW output from a few types of hardware through it to see what happened, and of course forgot about it. I'll do it first thing tomorrow (don't have my work laptop with me) and merge it.