search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
573 stars 99 forks source link

Update various dependencies to slightly later versions #573

Closed defect closed 6 years ago

defect commented 6 years ago

Mostly I just want to upgrade the mysql-connector versions prior to 5.1.40 are vulnerable to an exploit that was patched in April. While I was at it i bumped a couple of versions (mainly patch versions) while making sure it still builds and tests pass. I'll need to do a bit more smoke testing though.

The only code update i had to do was to update a method call since getAddressCount was deprecated in commons-net in favor of getAddressCountLong.

At some point I'd like to update to a play version newer than 2.3.x, but I believe they dropped java 7 support in 2.4.x.

@tumblr/collins

byxorna commented 6 years ago

@defect why is jvm7 a requirement? the docker image uses 8 fine

defect commented 6 years ago

@byxorna It's not, just that we're saying we support java 7 in the docs so we'll probably need a major version bump when we drop it :)