search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
573 stars 99 forks source link

Update the thor dependency constraint for collins-shell #578

Closed matthiasr closed 6 years ago

matthiasr commented 6 years ago

I need to install it alongside test-kitchen, which depends on <~ 0.19.0, so do the same here.

We have been using this internally for a little while now and it works fine. I have not tested even newer thor versions.

matthiasr commented 6 years ago

The test job that is failing is the one that's not even running Ruby … not sure if I can do anything about it?

defect commented 6 years ago

Yeah, sorry about that. The scala tests are a bit flakey. I'll open an issue about moving the ruby gems to their own repo(s).

This LGTM 👍

EDIT: Reran the non-ruby job and it finished