search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
573 stars 99 forks source link

Fix the ::Fixnum deprecation warning on Ruby 2.4+ #579

Closed matthiasr closed 6 years ago

matthiasr commented 6 years ago

Fixnum has been replaced by Integer (which used to be a parent class), triggering a very noisy warning.

It is actually safe to add the to_human_size method to Integer even on older Ruby version, so this change does that. To get confidence in this I needed to add some tests, so I needed to set up testing for collins-shell in the first place, which in turn required some Gem fixes.

defect commented 6 years ago

Seems cool to me, thanks! I'll give it a spin locally tomorrow (haven't used collins-shell in a while to be honest).

defect commented 6 years ago

Thanks again! I'm going to push a PR that updates the yard dependencies soon. I'll merge this and #578 at the same time, and bump the patch version.

defect commented 6 years ago

@matthiasr Looks like there's a conflict between this and #578. Could you rebase this on current master, or grab https://github.com/defect/collins/commit/0acc22b2aa1e0d3a7cf513c0ab04891843684663 which i think resolves it cleanly?

matthiasr commented 6 years ago

resolved! I think a general bundle update is also in order but I can submit that separately once this is merged (or you do it?)

matthiasr commented 6 years ago

(I also enabled "Allow edits from maintainers" so you should be able to push into my branch)