search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
573 stars 99 forks source link

Wrong URL returned for remote assets when querying from CLI with '--remote-lookup' #583

Closed nshalman closed 6 years ago

nshalman commented 6 years ago

With the release of collins-cli-0.2.12 I was very excited to be able to get results from multiple collins servers by querying a single one.

It generally appears to work, so thank you very much to everyone who made that possible!

I did manage to run into an odd corner case:

collins find --remote-lookup --link -n <some nodeclass>

The resulting URLs all point to the collins instance queried, not accurate URLs to whichever is the actual collins instance where they live.

I mentioned this to @michaeljs1990 and he suggested that this appeared to him to be a problem with data returned from collins itself rather than being an obvious bug in collins-cli

michaeljs1990 commented 6 years ago

Ops sorry that is my bad. This is actually an issue in collins-cli after taking one more look at it.

nshalman commented 6 years ago

Thank you for your excellent response time. :)