tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
573 stars 99 forks source link

.0 and .255 addresses never allocated in large pools #604

Open ssgelm opened 4 years ago

ssgelm commented 4 years ago

In pools larger than a /24 the internal .0 and .255 addresses (which are valid) are never allocated. This means that the pools effectively decrease in size by 2 addresses per /24 contained within a subnet. As far as I can tell this is caused by https://github.com/tumblr/collins/blob/master/app/collins/util/IpAddress.scala#L119-L126.