search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Minor code cleanup #493

Closed DanSimon closed 7 years ago

DanSimon commented 7 years ago

This PR has 2 main cleanup items:

  1. Several internal classes have been moved into a new colossus.core.server package, and a few larger files were split up. This was mainly done to avoid a conflict when importing both colossus.core and colossus.protocols.http.server, since both have an Initializer type. The one in core.server is no longer needed by users.
  2. Constructor parameters were accidentally switched on RequestHandler, putting them back in the right order.
codecov-io commented 7 years ago

Current coverage is 84.89% (diff: 80.76%)

Merging #493 into develop will decrease coverage by 0.02%

@@            develop       #493   diff @@
==========================================
  Files            95         98     +3   
  Lines          4257       4264     +7   
  Methods        3893       3913    +20   
  Messages          0          0          
  Branches        364        351    -13   
==========================================
+ Hits           3615       3620     +5   
- Misses          642        644     +2   
  Partials          0          0

Powered by Codecov. Last update ea128cf...109e89e