search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

#496 Make Websocket origin header optional #501

Closed shmishleniy closed 7 years ago

shmishleniy commented 7 years ago

issue https://github.com/tumblr/colossus/issues/496

codecov-io commented 7 years ago

Codecov Report

Merging #501 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #501      +/-   ##
=========================================
+ Coverage    83.7%   83.7%   +<.01%     
=========================================
  Files          79      79              
  Lines        3940    3941       +1     
  Branches      329     342      +13     
=========================================
+ Hits         3298    3299       +1     
  Misses        642     642
Impacted Files Coverage Δ
...scala/colossus/protocols/websocket/Websocket.scala 92.3% <100%> (+0.07%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbc9ae3...0610be6. Read the comment docs.

DanSimon commented 7 years ago

This looks good to me 👍 . If you haven't already, we'll need you to submit a CLA as described in our contributing guidelines before I can merge this in.

shmishleniy commented 7 years ago

Some problem with legal@tumblr.com

This is an automatically generated message. cmm@yahoo-inc.com is no longer with Yahoo! Inc. Your message will not be forwarded.

DanSimon commented 7 years ago

Hey @shmishleniy , apologies this is taking so long, I'm trying to get the situation resolved.

DanSimon commented 7 years ago

Ok it appears we did receive the CLA after all, so this is good to go