search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Fixed wrong Scaladoc parameters. #507

Closed mfirry closed 7 years ago

mfirry commented 7 years ago

Just delete old parameters that were still in the comments.

codecov-io commented 7 years ago

Codecov Report

Merging #507 into master will increase coverage by 0.07%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #507      +/-   ##
=========================================
+ Coverage   83.63%   83.7%   +0.07%     
=========================================
  Files          79      79              
  Lines        3941    3941              
  Branches      348     348              
=========================================
+ Hits         3296    3299       +3     
+ Misses        645     642       -3
Impacted Files Coverage Δ
...src/main/scala/colossus/metrics/MetricSystem.scala 90% <ø> (ø) :arrow_up:
.../main/scala/colossus/protocols/telnet/Telnet.scala 84.31% <0%> (+5.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b72b44e...2501a80. Read the comment docs.

DanSimon commented 7 years ago

Coolness 👍 . It might seem silly for this, but if you haven't already, we'll need to get a signed CLA from you before I can merge, details in the contributing guidelines

mfirry commented 7 years ago

Oh ok. Well this is a pretty silly contribution. I'd rather sign the CLA for bigger stuff.

benblack86 commented 7 years ago

Will do this in a separate PR