Closed mfirry closed 7 years ago
Merging #507 into master will increase coverage by
0.07%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #507 +/- ##
=========================================
+ Coverage 83.63% 83.7% +0.07%
=========================================
Files 79 79
Lines 3941 3941
Branches 348 348
=========================================
+ Hits 3296 3299 +3
+ Misses 645 642 -3
Impacted Files | Coverage Δ | |
---|---|---|
...src/main/scala/colossus/metrics/MetricSystem.scala | 90% <ø> (ø) |
:arrow_up: |
.../main/scala/colossus/protocols/telnet/Telnet.scala | 84.31% <0%> (+5.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b72b44e...2501a80. Read the comment docs.
Coolness 👍 . It might seem silly for this, but if you haven't already, we'll need to get a signed CLA from you before I can merge, details in the contributing guidelines
Oh ok. Well this is a pretty silly contribution. I'd rather sign the CLA for bigger stuff.
Will do this in a separate PR
Just delete old parameters that were still in the comments.