Have metric for commands executed in service client implementations

tumblr / colossus

I/O and Microservice library for Scala

Apache License 2.0

1.14k stars 96 forks source link

Have metric for commands executed in service client implementations #513

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

Suggested by @amotamed

DanSimon commented 7 years ago

Is this somehow different from the client-requests metric that already exists?

benblack86 commented 7 years ago

The idea was to have a more detailed metric than just # of requests. It would be broken by down by type of request. For example, in redis it would be tagged by command (https://redis.io/commands).

DanSimon commented 7 years ago

Ah ok, yeah this should be doable using the TagDecorator. Sounds like we'd just implement one for each protocol.