Closed DanSimon closed 7 years ago
Merging #519 into master will increase coverage by
0.1%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #519 +/- ##
=========================================
+ Coverage 83.7% 83.81% +0.1%
=========================================
Files 79 79
Lines 3941 3943 +2
Branches 348 351 +3
=========================================
+ Hits 3299 3305 +6
+ Misses 642 638 -4
Impacted Files | Coverage Δ | |
---|---|---|
...sus/src/main/scala/colossus/service/Callback.scala | 88.49% <100%> (+0.2%) |
:arrow_up: |
colossus/src/main/scala/colossus/core/Worker.scala | 79.01% <0%> (+1.78%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7413c20...bfd4bba. Read the comment docs.
This fixes a bug where if an exception was thrown in a
.mapTry
function, it would escape the callback's execution and bubble up, usually causing an unexpected connection error. Now they behave as they should.