search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Remove akka agent from iosystem #532

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

Replaced Agent with an AtomicReference. Whilst I was there I tidied up some code.

codecov-io commented 7 years ago

Codecov Report

Merging #532 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #532      +/-   ##
=========================================
- Coverage   80.61%   80.6%   -0.01%     
=========================================
  Files         117     117              
  Lines        4513    4512       -1     
  Branches      341     359      +18     
=========================================
- Hits         3638    3637       -1     
  Misses        875     875
Impacted Files Coverage Δ
...src/main/scala/colossus/metrics/MetricSystem.scala 90% <ø> (ø) :arrow_up:
.../src/main/scala/colossus/metrics/MetricClock.scala 60% <ø> (ø) :arrow_up:
...lossus/src/main/scala/colossus/core/IOSystem.scala 93.54% <100%> (-0.4%) :arrow_down:
...s/src/main/scala/colossus/core/WorkerManager.scala 87.36% <100%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1318f8a...cff9e96. Read the comment docs.

DanSimon commented 7 years ago

👍