search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Remove Agent from ServerRef #533

Closed aliyakamercan closed 7 years ago

aliyakamercan commented 7 years ago

Replaced Agent with an AtomicReference for #530

codecov-io commented 7 years ago

Codecov Report

Merging #533 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   84.74%   84.72%   -0.03%     
==========================================
  Files          98       98              
  Lines        4294     4294              
  Branches      338      365      +27     
==========================================
- Hits         3639     3638       -1     
- Misses        655      656       +1
Impacted Files Coverage Δ
...ossus/src/main/scala/colossus/core/ServerRef.scala 83.33% <100%> (ø) :arrow_up:
...s/src/main/scala/colossus/core/server/Server.scala 95.62% <100%> (ø) :arrow_up:
.../scala/colossus/metrics/collectors/Histogram.scala 91.91% <0%> (-0.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a29630...118e775. Read the comment docs.

jlbelmonte commented 7 years ago

👍