tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Pass http content type header to body #534

Closed dxuhuang closed 7 years ago

dxuhuang commented 7 years ago

@benblack86 @amotamed @jlbelmonte @aliyakamercan @DanSimon

https://github.com/tumblr/colossus/issues/499

codecov-io commented 7 years ago

Codecov Report

Merging #534 into master will increase coverage by 0.1%. The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #534     +/-   ##
=========================================
+ Coverage   84.71%   84.82%   +0.1%     
=========================================
  Files          98       98             
  Lines        4293     4309     +16     
  Branches      331      343     +12     
=========================================
+ Hits         3637     3655     +18     
+ Misses        656      654      -2
Impacted Files Coverage Δ
...a/colossus/protocols/http/HttpResponseParser.scala 72% <100%> (+8.84%) :arrow_up:
...main/scala/colossus/protocols/http/HttpParse.scala 100% <100%> (+9.67%) :arrow_up:
...la/colossus/protocols/http/HttpRequestParser.scala 95.65% <100%> (+0.91%) :arrow_up:
...n/scala/colossus/protocols/http/HttpResponse.scala 88.88% <100%> (ø) :arrow_up:
...rc/main/scala/colossus/protocols/http/Header.scala 83.85% <66.66%> (-0.53%) :arrow_down:
.../main/scala/colossus/protocols/http/HttpBody.scala 79.16% <83.33%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cb941f...3d92f06. Read the comment docs.

benblack86 commented 7 years ago

Code looks good, can we get some tests?

dxuhuang commented 7 years ago

bump