tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Refactor #536

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

Hopefully a minor PR.

codecov-io commented 7 years ago

Codecov Report

Merging #536 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   84.74%   84.71%   -0.03%     
==========================================
  Files          98       98              
  Lines        4293     4293              
  Branches      331      331              
==========================================
- Hits         3638     3637       -1     
- Misses        655      656       +1
Impacted Files Coverage Δ
...main/scala/colossus/protocols/redis/RedisOps.scala 95% <ø> (ø) :arrow_up:
...c/main/scala/colossus/service/RequestHandler.scala 88.88% <ø> (ø) :arrow_up:
...ain/scala/colossus/protocols/http/HttpClient.scala 90% <ø> (ø) :arrow_up:
...cala/colossus/protocols/memcache/MemcacheOps.scala 80.55% <ø> (ø) :arrow_up:
...lossus/src/main/scala/colossus/service/Async.scala 50% <ø> (ø) :arrow_up:
...in/scala/colossus/service/AsyncServiceClient.scala 100% <100%> (ø) :arrow_up:
...s/src/main/scala/colossus/service/ServiceDSL.scala 83.33% <100%> (ø) :arrow_up:
...s/src/main/scala/colossus/core/server/Server.scala 95.62% <100%> (ø) :arrow_up:
.../scala/colossus/metrics/collectors/Histogram.scala 91.91% <0%> (-0.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72ece1d...7942ed6. Read the comment docs.

amotamed commented 7 years ago

👍