search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Request tracing #552

Closed benblack86 closed 6 years ago

benblack86 commented 7 years ago

Todo...

diptamay commented 7 years ago

Planning to integrate with something like zipkin or https://uber.github.io/jaeger/ ?

benblack86 commented 7 years ago

No discovery done yet :)

DanSimon commented 7 years ago

Jaeger looks like it's based on OpenTracing, which looks pretty cool. I'll take a look to see how well their existing libraries would fit in with Colossus, but I have a gut feeling we'll have to implement the protocol ourselves (which I would prefer anyway to keep dependencies to a minimum).

The most important thing with this feature would be to make sure it doesn't affect performance or API complexity when not used. It should be an opt-in feature, but on the other hand, when it is used it shouldn't be overly complicated and should have the absolute minimum impact on performance.

benblack86 commented 6 years ago

Colossus 0.11.0 contains necessary changes to support this. We are playing around with request tracing internally and will release something once we are happy.