Package name should match directory

tumblr / colossus

I/O and Microservice library for Scala

Apache License 2.0

1.14k stars 96 forks source link

Package name should match directory #555

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

For example, HttpServer.scala contains HttpServer object (with other classes) and has package setup:

package colossus
package protocols.http
package server

However, the file is located in colossus/protocols/http directory. I find the multiple package statements confusing as it makes it harder to know where stuff is coming from. Not matching the directory means it is harder to know where to find a file. Thoughts?

benblack86 commented 7 years ago

FYI @aliyakamercan verbal agreed with this

DanSimon commented 7 years ago

Agreed, and this definitely fits in with overall library re-organization #410 . Hopefully we can get it all done in a single release.