search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Drop 2.10.6 Support #557

Closed aliyakamercan closed 7 years ago

aliyakamercan commented 7 years ago

554

@benblack86 @DanSimon @jlbelmonte @dxuhuang

codecov-io commented 7 years ago

Codecov Report

Merging #557 into develop will increase coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
+ Coverage    84.83%   84.85%   +0.02%     
===========================================
  Files           98       98              
  Lines         4313     4313              
  Branches       349      346       -3     
===========================================
+ Hits          3659     3660       +1     
+ Misses         654      653       -1
Impacted Files Coverage Δ
...s/src/main/scala/colossus/core/WorkerManager.scala 87.36% <0%> (ø) :arrow_up:
.../scala/colossus/metrics/collectors/Histogram.scala 92.64% <0%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 592c2ec...65b902f. Read the comment docs.

benblack86 commented 7 years ago

I fine dropping 2.10, but don't we also want to support 2.12? Or does 2.11 not work with the latest akka?

aliyakamercan commented 7 years ago

We need to update akka before that.

aliyakamercan commented 7 years ago

@benblack86 updated akka and added 2.12.

548 #372

DanSimon commented 7 years ago

LGTM 👍

The last time I tried building colossus on 2.12 it was significantly (but not dramatically) slower in benchmarks. I will be very interested to see how it does now.