Closed aliyakamercan closed 7 years ago
Merging #557 into develop will increase coverage by
0.02%
. The diff coverage is0%
.
@@ Coverage Diff @@
## develop #557 +/- ##
===========================================
+ Coverage 84.83% 84.85% +0.02%
===========================================
Files 98 98
Lines 4313 4313
Branches 349 346 -3
===========================================
+ Hits 3659 3660 +1
+ Misses 654 653 -1
Impacted Files | Coverage Δ | |
---|---|---|
...s/src/main/scala/colossus/core/WorkerManager.scala | 87.36% <0%> (ø) |
:arrow_up: |
.../scala/colossus/metrics/collectors/Histogram.scala | 92.64% <0%> (+0.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 592c2ec...65b902f. Read the comment docs.
I fine dropping 2.10, but don't we also want to support 2.12? Or does 2.11 not work with the latest akka?
We need to update akka before that.
@benblack86 updated akka and added 2.12.
LGTM 👍
The last time I tried building colossus on 2.12 it was significantly (but not dramatically) slower in benchmarks. I will be very interested to see how it does now.
crossScalaVersions
554
@benblack86 @DanSimon @jlbelmonte @dxuhuang