tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Operation tag decorator for redis and memcache clients #568

Closed aliyakamercan closed 7 years ago

aliyakamercan commented 7 years ago

fixes #513

@benblack86 @DanSimon @dxuhuang @nsauro

benblack86 commented 7 years ago

Is there a way to test?

codecov-io commented 7 years ago

Codecov Report

Merging #568 into develop will increase coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #568     +/-   ##
==========================================
+ Coverage    84.75%   84.95%   +0.2%     
==========================================
  Files           98       98             
  Lines         4422     4428      +6     
  Branches       349      352      +3     
==========================================
+ Hits          3748     3762     +14     
+ Misses         674      666      -8
Impacted Files Coverage Δ
...s/src/main/scala/colossus/service/ServiceDSL.scala 85.41% <100%> (ø) :arrow_up:
.../main/scala/colossus/protocols/redis/package.scala 44.44% <100%> (+27.77%) :arrow_up:
...in/scala/colossus/protocols/memcache/package.scala 100% <100%> (ø) :arrow_up:
.../main/scala/colossus/core/ConnectionSnapshot.scala 0% <0%> (ø) :arrow_up:
...n/scala/colossus/protocols/redis/RedisServer.scala 100% <0%> (ø) :arrow_up:
...ossus/protocols/http/streaming/StreamService.scala 82.35% <0%> (ø) :arrow_up:
...la/colossus/protocols/redis/RedisServerCodec.scala 80% <0%> (ø) :arrow_up:
...ossus/src/main/scala/colossus/core/DataBlock.scala 95.23% <0%> (ø) :arrow_up:
...cala/colossus/protocols/http/HttpServerCodec.scala 80% <0%> (ø) :arrow_up:
...ssus/src/main/scala/colossus/core/DataBuffer.scala 66.66% <0%> (ø) :arrow_up:
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3a3a43...bc951d7. Read the comment docs.

aliyakamercan commented 7 years ago

You can start the example http server with a metric sender.

benblack86 commented 7 years ago

What I meant was, can you write a test :)