tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Use a simple logger wrapper instead of Akka Logging #571

Closed aliyakamercan closed 7 years ago

aliyakamercan commented 7 years ago

@benblack86 @DanSimon @dxuhuang

fixes #409

codecov-io commented 7 years ago

Codecov Report

Merging #571 into develop will decrease coverage by 0.16%. The diff coverage is 54.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #571      +/-   ##
===========================================
- Coverage    84.69%   84.52%   -0.17%     
===========================================
  Files           98       99       +1     
  Lines         4422     4432      +10     
  Branches       360      357       -3     
===========================================
+ Hits          3745     3746       +1     
- Misses         677      686       +9
Impacted Files Coverage Δ
...sus/src/main/scala/colossus/service/Callback.scala 88.28% <ø> (ø) :arrow_up:
.../scala/colossus/metrics/senders/LoggerSender.scala 0% <0%> (ø) :arrow_up:
.../src/main/scala/colossus/metrics/MetricClock.scala 61.9% <0%> (ø) :arrow_up:
...cala/colossus/metrics/senders/OpenTsdbSender.scala 0% <0%> (ø) :arrow_up:
...src/main/scala/colossus/metrics/StatReporter.scala 73.91% <0%> (ø) :arrow_up:
.../main/scala/colossus/metrics/senders/package.scala 0% <0%> (ø) :arrow_up:
...rc/main/scala/colossus/service/ServiceClient.scala 91.6% <100%> (-2.8%) :arrow_down:
colossus/src/main/scala/colossus/core/Worker.scala 76.99% <37.5%> (-0.11%) :arrow_down:
...ala/colossus/metrics/logging/ColossusLogging.scala 58.33% <58.33%> (ø)
...s/src/main/scala/colossus/core/WorkerManager.scala 87.75% <63.63%> (ø) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7eddc1a...fcd9896. Read the comment docs.