Closed benblack86 closed 7 years ago
Merging #574 into develop will increase coverage by
0.02%
. The diff coverage is100%
.
@@ Coverage Diff @@
## develop #574 +/- ##
===========================================
+ Coverage 84.56% 84.58% +0.02%
===========================================
Files 99 99
Lines 4432 4432
Branches 357 357
===========================================
+ Hits 3748 3749 +1
+ Misses 684 683 -1
Impacted Files | Coverage Δ | |
---|---|---|
...in/scala/colossus/service/AsyncServiceClient.scala | 100% <ø> (ø) |
:arrow_up: |
...s/src/main/scala/colossus/service/ServiceDSL.scala | 85.41% <100%> (ø) |
:arrow_up: |
...s/src/main/scala/colossus/metrics/Collection.scala | 97.43% <0%> (-2.57%) |
:arrow_down: |
.../scala/colossus/metrics/collectors/Histogram.scala | 90.57% <0%> (-0.73%) |
:arrow_down: |
colossus/src/main/scala/colossus/core/Worker.scala | 77.87% <0%> (+0.88%) |
:arrow_up: |
...ssus/src/main/scala/colossus/core/Connection.scala | 69.31% <0%> (+1.13%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5cf27c...e27ecb3. Read the comment docs.
Ali and I were walking through the code and noticed some stuff that was unused and can be deleted. We didn't know what the "Gen" in
GenFutureClientFactory
stood for, so we deleted the "Gen".@aliyakamercan @dxuhuang @DanSimon @nsauro