tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

add option for reusing address #575

Closed dxuhuang closed 7 years ago

dxuhuang commented 7 years ago

@DanSimon @benblack86 @aliyakamercan @amotamed @jlbelmonte

https://github.com/tumblr/colossus/issues/498

codecov-io commented 7 years ago

Codecov Report

Merging #575 into develop will increase coverage by 0.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #575      +/-   ##
===========================================
+ Coverage    84.72%   84.73%   +0.01%     
===========================================
  Files           99       99              
  Lines         4438     4442       +4     
  Branches       366      370       +4     
===========================================
+ Hits          3760     3764       +4     
  Misses         678      678
Impacted Files Coverage Δ
...src/main/scala/colossus/metrics/ConfigHelper.scala 90.9% <100%> (+0.43%) :arrow_up:
.../src/main/scala/colossus/core/ServerSettings.scala 100% <100%> (ø) :arrow_up:
...s/src/main/scala/colossus/core/server/Server.scala 94.44% <66.66%> (-0.63%) :arrow_down:
...s/src/main/scala/colossus/metrics/Collection.scala 100% <0%> (+2.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 275a1e1...c299fb8. Read the comment docs.