search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

More Explicit Parameters #579

Closed dxuhuang closed 7 years ago

dxuhuang commented 7 years ago

Missed a few from last time

@DanSimon @benblack86 @aliyakamercan @amotamed @jlbelmonte

codecov-io commented 7 years ago

Codecov Report

Merging #579 into develop will increase coverage by 0.02%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #579      +/-   ##
===========================================
+ Coverage     84.9%   84.92%   +0.02%     
===========================================
  Files           99       99              
  Lines         4431     4431              
  Branches       367      367              
===========================================
+ Hits          3762     3763       +1     
+ Misses         669      668       -1
Impacted Files Coverage Δ
...scala/colossus/protocols/websocket/Websocket.scala 91.3% <ø> (ø) :arrow_up:
...ain/scala/colossus/protocols/http/HttpServer.scala 75% <0%> (ø) :arrow_up:
...protocols/http/streaming/StreamingHttpServer.scala 0% <0%> (ø) :arrow_up:
...s/src/main/scala/colossus/service/ServiceDSL.scala 85.41% <100%> (ø) :arrow_up:
...in/scala/colossus/service/AsyncServiceClient.scala 100% <100%> (ø) :arrow_up:
...s/src/main/scala/colossus/metrics/Collection.scala 100% <0%> (+2.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6073ed8...08cdf29. Read the comment docs.