search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Fix scala 2.12 warnings #588

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

Fixed scala 2.12 warnings, which were mainly about JavaConversions being deprecated. I then fixed some warnings from intellij. Fixes #576

@DanSimon @aliyakamercan @dxuhuang @nsauro

codecov-io commented 7 years ago

Codecov Report

Merging #588 into develop will increase coverage by 0.01%. The diff coverage is 91.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    84.94%   84.96%   +0.01%     
===========================================
  Files           99       99              
  Lines         4431     4430       -1     
  Branches       367      367              
===========================================
  Hits          3764     3764              
+ Misses         667      666       -1
Impacted Files Coverage Δ
...s/src/main/scala/colossus/core/server/Server.scala 94.44% <100%> (ø) :arrow_up:
...src/main/scala/colossus/metrics/ConfigHelper.scala 90.9% <100%> (ø) :arrow_up:
.../src/main/scala/colossus/metrics/MetricClock.scala 78.04% <81.81%> (-0.53%) :arrow_down:
.../scala/colossus/metrics/collectors/Histogram.scala 90.57% <90%> (-0.73%) :arrow_down:
colossus/src/main/scala/colossus/core/Worker.scala 77.87% <94.44%> (+0.88%) :arrow_up:
...s/src/main/scala/colossus/metrics/Collection.scala 97.43% <0%> (-2.57%) :arrow_down:
...ssus/src/main/scala/colossus/core/Connection.scala 69.31% <0%> (+1.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d15df26...6f5515f. Read the comment docs.