tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

More details on callbacks #592

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

Adding more details about the different callback implementations.

@DanSimon @aliyakamercan @dxuhuang @nsauro @jlbelmonte @amotamed

codecov-io commented 7 years ago

Codecov Report

Merging #592 into develop will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #592      +/-   ##
==========================================
- Coverage    84.94%   84.9%   -0.05%     
==========================================
  Files           99      99              
  Lines         4431    4431              
  Branches       378     378              
==========================================
- Hits          3764    3762       -2     
- Misses         667     669       +2
Impacted Files Coverage Δ
...sus/src/main/scala/colossus/service/Callback.scala 88.37% <ø> (ø) :arrow_up:
...s/src/main/scala/colossus/metrics/Collection.scala 97.43% <0%> (-2.57%) :arrow_down:
.../scala/colossus/metrics/collectors/Histogram.scala 90.57% <0%> (-0.73%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3853de...e4b00b1. Read the comment docs.

aliyakamercan commented 7 years ago

👍