search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Chinese opening to readme #595

Closed dxuhuang closed 7 years ago

dxuhuang commented 7 years ago

@DanSimon @benblack86 @jlbelmonte @amotamed @aliyakamercan

https://github.com/tumblr/colossus/issues/587

codecov-io commented 7 years ago

Codecov Report

Merging #595 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files          98       98           
  Lines        4312     4312           
  Branches      342      342           
=======================================
  Hits         3658     3658           
  Misses        654      654

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e8988d...6af3d53. Read the comment docs.

DanSimon commented 7 years ago

I like the initiative of getting a more diverse base of users and contributors, but I'm wondering how adding one line of Chinese to the readme is expected to help? Is this to try to get the repo's home page to show up in Chinese search results?

Also wondering if we should try to target other languages as well.

DanSimon commented 7 years ago

👍