tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

correct date format #606

Closed dxuhuang closed 7 years ago

dxuhuang commented 7 years ago

@benblack86 @DanSimon @jlbelmonte @aliyakamercan @amotamed

https://github.com/tumblr/colossus/issues/604

codecov-io commented 7 years ago

Codecov Report

Merging #606 into develop will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #606      +/-   ##
===========================================
+ Coverage    84.79%   84.88%   +0.08%     
===========================================
  Files           98       99       +1     
  Lines         4388     4452      +64     
  Branches       361      363       +2     
===========================================
+ Hits          3721     3779      +58     
- Misses         667      673       +6
Impacted Files Coverage Δ
...rc/main/scala/colossus/protocols/http/Header.scala 84.11% <100%> (+0.58%) :arrow_up:
...src/main/scala/colossus/metrics/MetricSystem.scala 93.18% <0%> (-2.06%) :arrow_down:
...s/src/main/scala/colossus/service/ServiceDSL.scala 85.41% <0%> (-1.82%) :arrow_down:
...ssus/src/main/scala/colossus/core/Connection.scala 68.18% <0%> (-1.59%) :arrow_down:
...in/scala/colossus/controller/InputController.scala 86.04% <0%> (-1.14%) :arrow_down:
...rc/main/scala/colossus/service/ServiceClient.scala 91.6% <0%> (-0.65%) :arrow_down:
...in/scala/colossus/protocols/memcache/package.scala 100% <0%> (ø)
...lossus/src/main/scala/colossus/core/Pipeline.scala 97.95% <0%> (+0.04%) :arrow_up:
.../scala/colossus/metrics/collectors/Histogram.scala 90.57% <0%> (+0.06%) :arrow_up:
...rc/main/scala/colossus/service/ServiceServer.scala 90.83% <0%> (+0.07%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72711b8...3d2026b. Read the comment docs.

benblack86 commented 7 years ago

Can we get a test?