tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Move akka teskkit so it's only a compile time dependency for colossus testkit #612

Closed benblack86 closed 7 years ago

benblack86 commented 7 years ago

It is now only a compile time dependency for colossus-testkit. Whilst there I also bump akka version (which caused the expectNoMsg to expectNoMsg change) and changed the port number used by TestkitExampleSpec since it always conflicts with other stuff I'm running.

Fixes #611

@dxuhuang @aliyakamercan @jlbelmonte @amotamed @DanSimon @nsauro

codecov-io commented 7 years ago

Codecov Report

Merging #612 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #612   +/-   ##
========================================
  Coverage    84.88%   84.88%           
========================================
  Files           99       99           
  Lines         4452     4452           
  Branches       361      328   -33     
========================================
  Hits          3779     3779           
  Misses         673      673

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f5b26d...8e85055. Read the comment docs.