search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Do we need separate server/service settings? #615

Closed benblack86 closed 6 years ago

benblack86 commented 7 years ago

The problem is that if overriding the defaults you end up with this:

colossus.server.service-name.max-connections = 4000
colossus.service.service-name.request-timeout = 1 second

Something like this would be better

colossus.service-name {
  max-connections = 4000
  request-timeout = 1 second
}
benblack86 commented 7 years ago

Server config is accessible to the service via ServerContext object.

benblack86 commented 6 years ago

Closing this for now since there is no clean way to change this.