tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Testing #634

Closed benblack86 closed 6 years ago

benblack86 commented 6 years ago

Added more documentation on testing. I'll comment below on some interesting points.

Fixes #618. Fixes #630.

@aliyakamercan @jlbelmonte @amotamed @dxuhuang @DanSimon

codecov-io commented 6 years ago

Codecov Report

Merging #634 into develop will increase coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #634      +/-   ##
===========================================
+ Coverage    85.43%   85.58%   +0.15%     
===========================================
  Files          105      105              
  Lines         4510     4510              
  Branches       408      408              
===========================================
+ Hits          3853     3860       +7     
+ Misses         657      650       -7
Impacted Files Coverage Δ
colossus/src/main/scala/colossus/core/Worker.scala 76.99% <0%> (-1.77%) :arrow_down:
...cala/colossus/protocols/memcache/MemcacheOps.scala 78.94% <0%> (+2.63%) :arrow_up:
...rc/main/scala/colossus/protocols/redis/Reply.scala 60% <0%> (+12%) :arrow_up:
...lossus/src/main/scala/colossus/service/Async.scala 70% <0%> (+20%) :arrow_up:
.../main/scala/colossus/protocols/redis/package.scala 100% <0%> (+55.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0094886...cc3fb13. Read the comment docs.