search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Log exception class #638

Closed dxuhuang closed 6 years ago

dxuhuang commented 6 years ago

@benblack86 @aliyakamercan @amotamed @jlbelmonte @DanSimon

https://github.com/tumblr/colossus/issues/633

codecov-io commented 6 years ago

Codecov Report

Merging #638 into develop will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #638      +/-   ##
===========================================
+ Coverage    84.75%   84.78%   +0.02%     
===========================================
  Files           99       99              
  Lines         4435     4435              
  Branches       412      394      -18     
===========================================
+ Hits          3759     3760       +1     
+ Misses         676      675       -1
Impacted Files Coverage Δ
...rc/main/scala/colossus/service/ServiceServer.scala 90.83% <100%> (ø) :arrow_up:
.../scala/colossus/metrics/collectors/Histogram.scala 91.3% <0%> (+0.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0deeb01...909a4ec. Read the comment docs.

benblack86 commented 6 years ago

Going to merge this and then write a test for it.