Closed benblack86 closed 6 years ago
Looks like I need to fix some integration tests.
Merging #643 into develop will decrease coverage by
0.2%
. The diff coverage is95%
.
@@ Coverage Diff @@
## develop #643 +/- ##
===========================================
- Coverage 84.73% 84.53% -0.21%
===========================================
Files 98 98
Lines 4384 4384
Branches 399 399
===========================================
- Hits 3715 3706 -9
- Misses 669 678 +9
Impacted Files | Coverage Δ | |
---|---|---|
...main/scala/colossus/protocols/redis/RedisOps.scala | 87.05% <95%> (-5.89%) |
:arrow_down: |
.../scala/colossus/metrics/collectors/Histogram.scala | 91.3% <0%> (+0.72%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 085b374...605d55c. Read the comment docs.
This PR simplifies the Redis API by merging calls that return an option with their counterparts that don't. In other words, returning an option is the default behavior. See https://github.com/tumblr/colossus/issues/632 for more details. Fixes #632
@DanSimon @aliyakamercan @jlbelmonte @amotamed