Colossus doesn't check existence of Host header

tumblr / colossus

I/O and Microservice library for Scala

Apache License 2.0

1.14k stars 96 forks source link

Colossus doesn't check existence of Host header #644

Closed aliyakamercan closed 6 years ago

aliyakamercan commented 6 years ago

https://tools.ietf.org/html/rfc7230#section-5.4

benblack86 commented 6 years ago

Just for my understanding, why is it useful?

benblack86 commented 6 years ago

If I understand the spec correctly, it is a MUST for the client to send. However, it doesn't say it is a MUST for the server to check for the existence.

aliyakamercan commented 6 years ago

It's not a valid HTTP req if it is not there. It is a spec thing, not sure if it's useful or not in colossus context.

benblack86 commented 6 years ago

Closing for now since we don't care