search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

maxResponseSize in Future Clients effectively limited to 10 MB by bytes Parser #656

Closed ksajme closed 6 years ago

ksajme commented 6 years ago

Construction of a Future Client by ClientFactories with an arbitrary maxResponseSize given in a ClientConfig is possible but an exception will be thrown if a response greater than 10 MB is received. https://github.com/tumblr/colossus/blob/master/colossus/src/main/scala/colossus/util/Parsing.scala#L304

This is due to the following overload which limits the bytes parser to 10 MB: https://github.com/tumblr/colossus/blob/master/colossus/src/main/scala/colossus/util/Parsing.scala#L323

jlbelmonte commented 6 years ago

Thanks for the report @ksajme. I will look into this.