search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Remove client interceptoprs #658

Closed aliyakamercan closed 6 years ago

aliyakamercan commented 6 years ago

@benblack86 @amotamed @jlbelmonte

Removing client interceptors for code cleanup. They weren't helpful after all.

codecov-io commented 6 years ago

Codecov Report

Merging #658 into develop will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #658      +/-   ##
===========================================
+ Coverage     85.7%   85.78%   +0.07%     
===========================================
  Files          105      105              
  Lines         4506     4495      -11     
  Branches       406      403       -3     
===========================================
- Hits          3862     3856       -6     
+ Misses         644      639       -5
Impacted Files Coverage Δ
...s/src/main/scala/colossus/service/ServiceDSL.scala 81.13% <ø> (+1.5%) :arrow_up:
...in/scala/colossus/service/AsyncServiceClient.scala 91.89% <ø> (+4.71%) :arrow_up:
...n/scala/colossus/service/LoadBalancingClient.scala 86.88% <ø> (+1.4%) :arrow_up:
...lossus/src/main/scala/colossus/service/Async.scala 70% <ø> (ø) :arrow_up:
...src/main/scala/colossus/service/LoadBalancer.scala 91.07% <ø> (-0.6%) :arrow_down:
...rc/main/scala/colossus/service/ServiceClient.scala 93.05% <100%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update add9222...3d60565. Read the comment docs.