tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Obligatory example on page #674

Closed wibisono closed 5 years ago

wibisono commented 5 years ago

I managed to run the first example on docs only after changing request handler line into:

case request @ Get on Root => Callback.successful(request.ok("Hello world!"))

With the callback successful. No big deal but rather bumpy first experience.

dkarivalis commented 5 years ago

hey @wibisono! quickly tested the hello world example and am not seeing the same results:

screen shot 2018-11-02 at 11 01 20 am

which scala / sbt version are you using?

wibisono commented 5 years ago

Hi,

Maybe that's the issue, I am using sbt 1.2.6 and scala 2.12.7: Idea

dkarivalis commented 5 years ago

Hi,

Maybe that's the issue, I am using sbt 1.2.6 and scala 2.12.7: https://imgur.com/a/P1P7iCY

ahh i believe you may need import colossus.service.Callback.Implicits._ for the implicit conversion. mind giving that a try?

wibisono commented 5 years ago

That works :) sorry for the trouble, thanks.