search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

LoadBalancer: disconnecting deadClients on #update(...) #678

Closed dkarivalis closed 5 years ago

dkarivalis commented 5 years ago

what

small fix for a bug where #update(...)'ing the addresses of a LoadBalancer would not disconnect clients no longer in use

@vrrs @kevinsteck cc @benblack86

codecov-io commented 5 years ago

Codecov Report

Merging #678 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #678      +/-   ##
===========================================
+ Coverage    85.65%   85.65%   +<.01%     
===========================================
  Files          105      105              
  Lines         4524     4525       +1     
  Branches       424      408      -16     
===========================================
+ Hits          3875     3876       +1     
  Misses         649      649
Impacted Files Coverage Δ
...src/main/scala/colossus/service/LoadBalancer.scala 91.22% <100%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3939cce...18739f0. Read the comment docs.