search

tumblr / colossus

I/O and Microservice library for Scala
Apache License 2.0
1.14k stars 96 forks source link

Adding Scala 2.13 support #681

Open plokhotnyuk opened 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #681 into develop will decrease coverage by 1.3%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
- Coverage    85.67%   84.37%   -1.31%     
===========================================
  Files          105      111       +6     
  Lines         4525     4589      +64     
  Branches       408      276     -132     
===========================================
- Hits          3877     3872       -5     
- Misses         648      717      +69
Impacted Files Coverage Δ
...rc/main/scala/colossus/service/ServiceServer.scala 92.38% <0%> (-1.91%) :arrow_down:
...sus/src/main/scala/colossus/service/Callback.scala 87.59% <0%> (-1.56%) :arrow_down:
.../scala/colossus/metrics/collectors/Histogram.scala 90.57% <0%> (-0.73%) :arrow_down:
...ain/scala/colossus.examples/WebsocketExample.scala 0% <0%> (ø)
...c/main/scala/colossus.examples/KeyValExample.scala 0% <0%> (ø)
...scala/colossus.examples/StreamServiceExample.scala 0% <0%> (ø)
...ain/scala/colossus.examples/BenchmarkExample.scala 0% <0%> (ø)
...amples/src/main/scala/colossus.examples/Main.scala 0% <0%> (ø)
...src/main/scala/colossus.examples/HttpExample.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af0e5c1...a396818. Read the comment docs.

simpadjo commented 4 years ago

For those who want to run colossus on scala-2.13, I finalized PR by @plokhotnyuk in my repo: https://github.com/simpadjo/colossus . I also published the packages (snapshots for now) but apparently they are not usable from build tools w/o a token due to github quirks.