search

tumblr / genesis

A tool for data center automation
http://tumblr.github.io/genesis/
Apache License 2.0
156 stars 24 forks source link

make dhcp timeout 40s instead of 15s #60

Closed byxorna closed 8 years ago

byxorna commented 8 years ago

Some DHCP relay configurations make DHCP take a really long time to do its dance. Try to guard against this.

@roymarantz @schallert @Primer42

roymarantz commented 8 years ago

How did you choose 40?

byxorna commented 8 years ago

@roymarantz how did we choose 15 originally? ;) Anything less and I've seen sporadic timeouts when renewing leases in our infrastructure

roymarantz commented 8 years ago

Seems like 50 or 60 would be safer numbers then to have a "safety" factor. Have the genesis boot process slow down by 10 or 20 extra seconds doesn't sound like a big deal. (read that it already is pretty slow) What do you think?

On Mon, Jul 18, 2016 at 9:38 AM, Gabe Conradi notifications@github.com wrote:

@roymarantz https://github.com/roymarantz how did we choose 15 originally? ;) Anything less and I've seen sporadic timeouts when renewing leases in our infrastructure

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tumblr/genesis/pull/60#issuecomment-233330714, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2LSiARb15g3uVTyBro0ELNzHkdbWfUks5qW4HngaJpZM4JNopB .

william-richard commented 8 years ago

LGTM with 40 - I would also be happy with going up to 60, or anything in the middle.

byxorna commented 8 years ago

@roymarantz totally agreed. Ill bump it to a nice round 60.

gtorre commented 8 years ago

👍

schallert commented 8 years ago

LGTM