search

tumblr / genesis

A tool for data center automation
http://tumblr.github.io/genesis/
Apache License 2.0
155 stars 24 forks source link

Basic support for LogLevel #69

Closed xakraz closed 7 years ago

xakraz commented 7 years ago

May resolve #54

xakraz commented 7 years ago

@byxorna : Updated !

roymarantz commented 7 years ago

I wonder if defining a log_crit(), log_emerg(), log_info() would be better than passing another parameter. What do you think?

byxorna commented 7 years ago

I'd honestly prefer a single log method. For backends that don't support severity, it doesn't make sense to have many copy pasted methods for log_crit and log_warn when critical and warning don't even make sense for this fictional logging system. Optional parameters keep api surface lean and understandable imho

roymarantz commented 7 years ago

lgtm