search

tumblr / genesis

A tool for data center automation
http://tumblr.github.io/genesis/
Apache License 2.0
155 stars 24 forks source link

Convert GENESIS_PROMPT_TIMEOUT to integer #74

Closed defect closed 5 years ago

defect commented 7 years ago

Tiny little fix for a bug i ran into today. If you set the env variable GENESIS_PROMPT_TIMEOUT to something other than 0 it'll fail because it hasn't been cast to an integer when passing to Genesis::PromptCLI, resulting in a TypeError when trying to add an integer with a string in promptcli.

@roymarantz @qx-xp @gtorre

defect commented 6 years ago

@tumblr/collins bump! I rebased to latest and ++'ed the version of the framework gem.

roymarantz commented 6 years ago

still lgtm and my comment about using a float still applies, but is not a blocker