tumblr / jumblr

Tumblr API v2 Java Client
Apache License 2.0
278 stars 105 forks source link

Updated JumblrException to correctly parse errors from response body. #129

Open ndtreviv opened 5 years ago

ndtreviv commented 5 years ago

Fixes #91

In this version JumblrException correctly parses error objects and stores error details in a new JumblrError type, which makes the code, title and detail accessible to the end user.

yahoocla commented 5 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

ndtreviv commented 5 years ago

Ah great. I had printed out that CLA file and was just about to scan it, but that online form is much easier! Done.

ndtreviv commented 5 years ago

There are some pretty old PRs in here. I really need this fix, actually. So I'm wondering what the movement time is on these PRs? Am I better off just deploying my fork instead?