tumblr / jumblr

Tumblr API v2 Java Client
Apache License 2.0
278 stars 105 forks source link

Add the missing reblog info fields to Post #80

Closed KevinTCoughlin closed 8 years ago

KevinTCoughlin commented 8 years ago

Overview

This adds the missing reblog_* fields to Post.java brought up in #76.

Concerns

Example existing test:

        Map<String, Object> flat = new HashMap<String, Object>();
        flat.put("type", "text");
        flat.put("title", title);
        flat.put("body", body);
        flat.put("note_count", noteCount);
        flat.put("reblogged_from_id", rebloggedFromId);
        flat.put("reblogged_from_name", rebloggedFromName);
        Gson gson = new GsonBuilder().registerTypeAdapter(Post.class, new PostDeserializer()).create();
        post = (TextPost) gson.fromJson(flatSerialize(flat), Post.class);
ceyko commented 8 years ago

Maybe just update the doc for the root varieties to say that they're the data for the root post / root post's blog.

Agree, tests are a bit weak. I'm good either way - adding them or not.

Will update the api docs to reflect these fields.