tumblr / k8s-sidecar-injector

Kubernetes sidecar injection service

Apache License 2.0

345 stars 75 forks source link

Updating documentation around kubernetes example deployment. #11

Closed shivaprasad201 closed 5 years ago

shivaprasad201 commented 5 years ago

What and why?

Added documentation for creating k8s secret from which the controller will pick up the certificates Changed names for env variables to use the cert names created as a part of tls.

Testing Steps

Just docs and config changes :)

Reviewers

Required reviewers: @byxorna Request reviews from other people you want to review this PR in the "Reviewers" section on the right.

:warning: this PR must have at least 2 thumbs from the MAINTAINERS.md of the project before merging!

yahoocla commented 5 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile: