tumblr / k8s-sidecar-injector

Kubernetes sidecar injection service

Apache License 2.0

345 stars 75 forks source link

Corrects error message for missing request annotation #14

Closed shrey-rajvanshi closed 5 years ago

shrey-rajvanshi commented 5 years ago

What and why?

If the pod is missing request annotation, the error message says status annotation key missing when it should say request annotation missing..

Testing Steps

NA.

Reviewers

Required reviewers: @byxorna Request reviews from other people you want to review this PR in the "Reviewers" section on the right.

:warning: this PR must have at least 2 thumbs from the MAINTAINERS.md of the project before merging!

yahoocla commented 5 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

byxorna commented 5 years ago

@shrey-rajvanshi great catch, thanks for the PR! Would you mind filling out the CLA as mentioned above, and I can get this merged?

shrey-rajvanshi commented 5 years ago

I signed it.

byxorna commented 5 years ago

Cool, thanks @shrey-rajvanshi! Merging :)