tumblr / k8s-sidecar-injector

Kubernetes sidecar injection service
Apache License 2.0
345 stars 75 forks source link

Document configuration name error #24

Closed zhangjianweibj closed 4 years ago

zhangjianweibj commented 5 years ago

documents comment:

sidecar configs are identified by a requesting

annotation, like:

"injector.tumblr.com/request=tumblr-php"

the "name: tumblr-php" must match a configuration below;

but configuration is name: "test"

byxorna commented 5 years ago

@newfurniturey @zhangjianweibj has previously signed the CLA, so this is good to merge (https://github.com/tumblr/k8s-sidecar-injector/pull/22#issuecomment-533032419).

newfurniturey commented 5 years ago

@byxorna hold off on that for a moment; we may need to have our new CLA signed first (new parent company, new rules). Getting clarification at this time, can update here when I have more info

alex-laties commented 4 years ago

stale, will fix in a separate commit. thanks for bringing it to our attention!