tumblr / k8s-sidecar-injector

Kubernetes sidecar injection service

Apache License 2.0

345 stars 75 forks source link

adding support for setting serviceAccountName #30

Closed byxorna closed 4 years ago

byxorna commented 5 years ago

What and why?

Adding support to inject serviceaccounts! If a service account is already present in the pod, skip overwriting it.

NOTE: this will not work for you if you are on versions < 1.15.0 of Kubernetes, due to https://github.com/kubernetes/kubernetes/pull/78080

Testing Steps

[x] Added unit tests for this feature (make test)

Reviewers

Required reviewers: @byxorna Request reviews from other people you want to review this PR in the "Reviewers" section on the right.

:warning: this PR must have at least 2 thumbs from the MAINTAINERS.md of the project before merging!

byxorna commented 4 years ago

@komapa @alex-laties re-RFR please!