Open ribbybibby opened 4 years ago
@byxorna @kirooshu @alex-laties
@ribbybibby, I agree that workaround is good until there is a proper solution. What I would recommend as a patch here though is to have a flag for prepend all or append all (current behavior). I think having the prependContainers is confusing and most of the time you do not really care if there are some other containers between your "sidecar" container and the main container, they can start just as normal if they do not have the postStart logic.
So I would vote here for just having a global flag on the injection config for whether to prepend the containers or append (default) and that should solve your use case, right?
Thanks for looking at the PR @kirooshu. Yep, that works for me. I'll make the changes.
@kirooshu I've pushed the suggested changes.
:bow: Thanks for the approve @kirooshu. Is this good to be merged?
Ping - just checking if anyone has had a chance to look at this? @alex-laties @defect
What and why?
Adds a field which allows sidecars to be prepended to the top of the list of the containers. This allows use of this workaround for delaying an application until the sidecars are ready: https://medium.com/@marko.luksa/delaying-application-start-until-sidecar-is-ready-2ec2d21a7b74
Issue: #49
Testing Steps
Please provide adequate testing steps (including screenshots if necessary). Include any test fixtures or sample configurations in your commit.
make test
)Reviewers
Required reviewers:
@byxorna
Request reviews from other people you want to review this PR in the "Reviewers" section on the right.